[Bug 686459] pulsesink: playbin uri=x.mp3 audio-sink='identity ! pulsesink' => not-negotiated flow error

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=686459
  GStreamer | gst-plugins-good | git

--- Comment #17 from Brendan Long <self at brendanlong.com> 2013-06-12 23:15:13 UTC ---
Created an attachment (id=246676)
 View: https://bugzilla.gnome.org/attachment.cgi?id=246676
 Review: https://bugzilla.gnome.org/review?bug=686459&attachment=246676

Check for PA_MAJOR >= 2 before using pa_format_info_get_prop_* functions

The pa_format_info_get_prop_* functions were added in libpulse 2.0
(http://freedesktop.org/software/pulseaudio/doxygen/format_8h.html#aae6ab2ad009c17d0f999ce1011d99f08),
so commit 14e784f9fc629af4c33b41dae159aa5060fb8f5f makes gst-plugins-good not
build on Ubuntu 12.04:

  CC     libgstpulse_la-pulseutil.lo
pulsesink.c: In function 'gst_pulse_format_info_int_prop_to_value':
pulsesink.c:2028:3: error: implicit declaration of function
'pa_format_info_get_prop_int' [-Werror=implicit-function-declaration]
pulsesink.c:2028:3: error: nested extern declaration of
'pa_format_info_get_prop_int' [-Werror=nested-externs]
pulsesink.c:2032:3: error: implicit declaration of function
'pa_format_info_get_prop_int_array' [-Werror=implicit-function-declaration]
pulsesink.c:2032:3: error: nested extern declaration of
'pa_format_info_get_prop_int_array' [-Werror=nested-externs]
pulsesink.c:2043:3: error: implicit declaration of function
'pa_format_info_get_prop_int_range' [-Werror=implicit-function-declaration]
pulsesink.c:2043:3: error: nested extern declaration of
'pa_format_info_get_prop_int_range' [-Werror=nested-externs]
pulsesink.c: In function 'gst_pulse_format_info_to_caps':
pulsesink.c:2066:7: error: implicit declaration of function
'pa_format_info_to_sample_spec' [-Werror=implicit-function-declaration]
pulsesink.c:2066:7: error: nested extern declaration of
'pa_format_info_to_sample_spec' [-Werror=nested-externs]
pulsesink.c:2068:7: error: implicit declaration of function
'pa_format_info_get_prop_string' [-Werror=implicit-function-declaration]
pulsesink.c:2068:7: error: nested extern declaration of
'pa_format_info_get_prop_string' [-Werror=nested-externs]

This patch just requires libpulse >= 2.0, since that will fix the build. It may
be nicer to keep building pulsesink and just use the old behavior if PA_MAJOR <
2.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.