[Bug 698562] gstrtpbuffer.c: broken language bindings for gst_rtp_buffer_get_payload

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=698562
  GStreamer | gst-plugins-base | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #246771|none                        |needs-work
             status|                            |

--- Comment #13 from Sebastian Dröge <slomo at circular-chaos.org> 2013-06-14 13:15:59 UTC ---
Review of attachment 246771:
 --> (https://bugzilla.gnome.org/review?bug=698562&attachment=246771)

::: gst-libs/gst/rtp/gstrtpbuffer.c
@@ +713,3 @@
+gboolean
+gst_rtp_buffer_get_extension_bytes (GstRTPBuffer * rtp, guint16 * bits,
+    GBytes ** data)

I think this should just return a GBytes instead of having the out parameter

@@ +727,3 @@
+    *data = g_bytes_new (buf_data, 4 * buf_len);
+  } else {
+    *data = NULL;

And in the buf_len==0 case just return an empty GBytes

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.