[Bug 702548] problem with authentication for tunneled clients

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=702548
  GStreamer | gst-rtsp-server | 1.x

--- Comment #4 from Wim Taymans <wim.taymans at gmail.com> 2013-06-21 10:21:07 UTC ---
(In reply to comment #3)
> I know I can use the gst_rtsp_client_set_auth function. My question is if it's
> ok to modify the gst_rtsp_server_transfer_connection to include a boolean
> wheter or not to use gst_rtsp_client_set_auth to disable authentication for
> that client.

I don't like the boolean that sets the auth to NULL. I think it should be
something less dramatic. Some options:

1) add auth to the transfer function to use as the auth manager for this
transfered connection. A little weird, you would want to use the same auth
manager as the other clients, maybe with some relaxed or different behaviour.

2) Mark the client as being 'authenticated' and let the auth manager skip the
password setup and checks. It sounds conceptually better. You would need a way
mark the client state somehow, maybe add a vmethod when a client is transfered?
again, it should still be possible to do the auth over the tunneled connection.

You can now take the client-connected signal, check if the connection is
tunneled and set a NULL auth, if you want.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.