[Bug 701287] gnonlin: API should be revisited before1.X first versions

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=701287
  GStreamer | gnonlin | git

--- Comment #12 from Thibault Saunier <thibault.saunier at collabora.com> 2013-06-22 19:23:44 UTC ---
(In reply to comment #10)
> Subtile left over:
> 
> White line, see gnlcomposition line 1855 and 2939
>                         check/gnl/common.c line 209
> Bad indent, see gnlobject.h lines 133,134,135
> 
> Other then that, I still think it would be better to have that scenario:
> 
> start = 0;
> g_object_set (obj, "start", 1, NULL);
> g_object_get (obj, "start", &start, NULL);
> g_assert (start == 1);
> 
> Which imply that notify:: signal are emited right away. Anyway, we sort right
> after having commited the objects. Then you can remove the code to hide the
> signals (which seems to fight against the way propreties work). It is cleaner,
> and emiting just in time does not provide much that can be used by the
> application.
> 
> I have not found anything else in this pass.

I updated my branch to do it the way described here. It indeed makes the code
simpler.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.