[Bug 701101] If a sink is in async, pipeline reports wrong position

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Jun 25 11:42:17 PDT 2013


http://bugzilla.gnome.org/show_bug.cgi?id=701101
  GStreamer | gstreamer (core) | git

--- Comment #3 from Wim Taymans <wim.taymans at gmail.com> 2013-06-25 18:42:11 UTC ---
(In reply to comment #2)
> Thanks Wim for the fix but this doesn't fix the issue of dead code I mentioned
> in the bug report, which might affect other logic in the basesink.
> 
> For example, the current_sstop and current_rstop will still be set to the
> segment stop if a buffer's duration is invalid, which will affect other parts
> of the code like the calculation of max_lateness, or the perform_qos.
> Was there any reason that the patch I attached was rejected and you decided to
> fix it differently ? Let me know if there's anything I need to change in the
> attached patch.
> Thanks.

I didn't want to touch that logic, mostly. A -1 duration by definition means
'until the next buffer' or end of segment, so this logic extends the end time
of a buffer with -1 duration to the end of the segment.

I will have to take a deeper look later.

-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list