[Bug 702845] glshader element does not read shader file correctly

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=702845
  GStreamer | gst-plugins-gl | 0.10.3

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |t.i.m at zen.co.uk
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.4

--- Comment #1 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2013-06-27 23:12:01 UTC ---
Thanks, should be fixed by this as well hopefully:


commit 8cbd495b5e71ef9a8604749e8c03190d6d314138
Author: Tim-Philipp Müller <tim at centricular.net>
Date:   Fri Jun 28 00:04:43 2013 +0100

    glfiltershader: fix crash when loading shader file

    Just use g_file_get_contents() instead of home-made file loading.
    Fixes two issues - one is that we should pass "r" to fopen and
    not O_RDONLY, the other is that an incorrect variable was used
    to read the file length, leading to an empty shader file.

    Spotted by: Wang Xin-yu (王昕宇) <comicfans44 at gmail.com>

    https://bugzilla.gnome.org/show_bug.cgi?id=702844
    https://bugzilla.gnome.org/show_bug.cgi?id=702845

    Conflicts:
        gst/gl/gstglfiltershader.c

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.