[Bug 695215] New: Possible bug in gstbasetransform.c

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=695215
  GStreamer | gstreamer (core) | 1.0.5

           Summary: Possible bug in gstbasetransform.c
    Classification: Platform
           Product: GStreamer
           Version: 1.0.5
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: visechelle at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=238129)
 View: https://bugzilla.gnome.org/attachment.cgi?id=238129
 Review: https://bugzilla.gnome.org/review?bug=695215&attachment=238129

Patch

In gst_base_transform_acceptcaps_default(), gst_caps_is_subset() is used to
check whether the caps in the query are a subset of the caps on the sink/src
pad of the element. As specified in GStreamer doc about gst_caps_is_subset:

"This function does not work reliably if optional properties for caps are
included on one caps and omitted on the other."

Therefore, I think gst_caps_can_intersect should be used instead (see patch).
By the way the original comment speak about "intersect".
What do you think?

Cheers,

Paul HENRYS

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.