[Bug 690934] tsdemux: setting program-number has no effect

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=690934
  GStreamer | gst-plugins-bad | 1.0.3

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |t.i.m at zen.co.uk
     Ever Confirmed|0                           |1

--- Comment #4 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2013-03-07 00:55:08 UTC ---
With the patch it looks almost correct to me, but not fully.

If I'm not mistaken, there are two cases:

a) program-number not set via property. In that case it's -1 to start with, and
then it will be set to the first program number that is found, until the end of
the program or shutdown, when it will be reset to -1 again.

b) program-number is set via property, then it should always stay as set and
never be reset to -1, not even on shutdown or when program_stopped is called.


With the patch, the resetting on shutdown  is not handled properly any more in
scenario (a), so if the element gets reused it will try to use the number that
was last active.

With the patch, it's still reset to -1 in program_stopped, so is not permanent
across re-use or within the same stream even. (This might be on purpose, I'm
not sure).

I think we need two variables, one for the program number as set via the
property, that is only ever changed via the property, and one for the 'current
program number' that's reset based on the property setting (-1 or whatever was
set).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.