[Bug 695643] dvdemux: returns wrong value when it is not processing the sink events

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Mar 11 17:12:46 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=695643
  GStreamer | gst-plugins-good | 1.0.5

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEEDINFO
                 CC|                            |t.i.m at zen.co.uk

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2013-03-12 00:12:45 UTC ---
Does this also make it work?


diff --git a/ext/dv/gstdvdemux.c b/ext/dv/gstdvdemux.c
index ab6e39e..a2b89f4 100644
--- a/ext/dv/gstdvdemux.c
+++ b/ext/dv/gstdvdemux.c
@@ -651,8 +651,10 @@ gst_dvdemux_push_event (GstDVDemux * dvdemux, GstEvent *
event)

   if (dvdemux->audiosrcpad)
     res |= gst_pad_push_event (dvdemux->audiosrcpad, event);
-  else
+  else {
     gst_event_unref (event);
+    res = TRUE;
+  }

   return res;
 }


If the default is true, the res |= xyz become a bit pointless.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list