[Bug 695655] audiovisualizer: crash while clearing video frame

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=695655
  GStreamer | gst-plugins-bad | 1.0.5

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #238622|none                        |reviewed
             status|                            |

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2013-03-12 00:32:55 UTC ---
(From update of attachment 238622)
Thanks for the patch!

>       /* gst_video_frame_clear() or is output frame already cleared */
>-      memset (outframe.data, 0, scope->vinfo.size);
>+      for (i = 0; i < scope->vinfo.finfo->n_planes; i++) {
>+        memset (outframe.data[i], 0, scope->vinfo.size);
>+      }

I'm not sure if this (scope->vinfo.size) is entirely right here for more than 1
plane, though of course all visualizers in this plugin only support BGRx for
now, so there's only one plane.

There doesn't appear to be a convenient way to get the plane size as far as I
can see (maybe frame.map[i].size?).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.