[Bug 695728] x264enc plugin has a divide by zero error when framerate is "0/1"

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=695728
  GStreamer | gst-plugins-ugly | 1.0.1

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #238739|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge <slomo at circular-chaos.org> 2013-03-13 08:24:10 UTC ---
Review of attachment 238739:
 --> (https://bugzilla.gnome.org/review?bug=695728&attachment=238739)

::: ext/x264/gstx264enc.c
@@ +1055,3 @@
+  if (info->fps_d == 0 || info->fps_n == 0) {
+    // No FPS so must use VFR
+    // This raises latency apparently see
http://mewiki.project357.com/wiki/X264_Encoding_Suggestions

Please use C-style comments, i.e. /* blablabla */

@@ +1058,3 @@
+    encoder->x264param.b_vfr_input = TRUE;
+    // TODO set timebase from clock rate
+    // Clock rate seems to not be sent through however

I don't think there even is a useful way of getting a clock rate here... and if
it isn't used by x264 it doesn't matter anyway, right?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.