[Bug 695709] vp8enc plugin has invalid parameter error when framerate is "0/1"

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=695709
  GStreamer | gst-plugins-good | 1.0.5

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #238728|none                        |needs-work
             status|                            |

--- Comment #7 from Sebastian Dröge <slomo at circular-chaos.org> 2013-03-13 08:27:02 UTC ---
Review of attachment 238728:
 --> (https://bugzilla.gnome.org/review?bug=695709&attachment=238728)

::: ext/vpx/gstvp8enc.c
@@ +1512,3 @@
+  if (GST_VIDEO_INFO_FPS_D (info) == 0 || GST_VIDEO_INFO_FPS_N (info) == 0) {
+    encoder->cfg.g_timebase.num = 1;
+    encoder->cfg.g_timebase.den = 90000;

Why use a timebase of 1/90000 here? Please add a comment at least :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.