[Bug 696032] New: [mpegtsmux] Downstream force-key-unit events are being assigned the wrong "count"

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=696032
  GStreamer | gst-plugins-bad | 1.0.5

           Summary: [mpegtsmux] Downstream force-key-unit events are being
                    assigned the wrong "count"
    Classification: Platform
           Product: GStreamer
           Version: 1.0.5
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: anton at angri.ru
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


In mpegtsmux/mpegtsmux.c function check_pending_key_unit_event() always assumes
that the pending_event is upstream, which is not always the case - function
mpegtsmux_sink_event() assigns an event of downstream type to
mux->force_key_unit_event, which later gets passed to
check_pending_key_unit_event().

In case when the actual event is downstream, parsing it as an upstream one
doesn't work right, in particular it assigns wrong values to count variable. In
my setup those count values were changing unpredictably or in many cases not
changing in subsequent FKU events, and thus propagation of that FKU event
downstream would stop.

Attached patch fixes the issue.

Please note also that there is probably an analogous problem in
videoparsers/gsth264parse.c which has almost identical implementation of
check_pending_key_unit_event().

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.