[Bug 684237] videomixer: Caps negotiation does not always work

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Mar 25 01:02:42 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=684237
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at circular-chaos.org

--- Comment #35 from Sebastian Dröge <slomo at circular-chaos.org> 2013-03-25 08:02:35 UTC ---
(In reply to comment #34)
> Review of attachment 229285 [details]:
> 
> One of the issue I just found is that the gst_videomixer2_sinkpads_getcaps()
> should reset the width and height to a range, so any size can be mixed
> together. Then I think gst_videomixer2_pad_sink_getcaps() should do a
> gst_pad_peer_query_caps() on the srcpad somewhere to be correct.

Sounds both sensible, yes. But the peer caps should have their width/height
removed (we can mix anything, even 1920x1080 to a 320x240 output).

And in any case you need to conserve the PAR that is required downstream and
also enforce the same PAR on all sinkpads (same goes for the format field).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list