[Bug 696542] New: tests: remove extra unref in test_setup_non_existing_stream

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Mar 25 02:54:30 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=696542
  GStreamer | gst-rtsp-server | git

           Summary: tests: remove extra unref in
                    test_setup_non_existing_stream
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-rtsp-server
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: davidsf at axis.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=239737)
 View: https://bugzilla.gnome.org/attachment.cgi?id=239737
 Review: https://bugzilla.gnome.org/review?bug=696542&attachment=239737

Remove extra unref

In rtspserver unit tests, there is an extra server unref at the end of
test_setup_non_existing_stream, which is not needed (anymore). The unref was
added because, at the time of writing, the test didn't complete without it. The
attached suggested patch removes the extra unref.

This method can be used for checking that the test completes with the patch:

GST_DEBUG=check:7 GST_CHECKS=test_setup_non_existing_stream make -C tests/check
gst/rtspserver.check

At the end of the output, gstcheck prints "cleaning up tasks", which means that
the test has completed. The server is unreffed in the fixture teardown instead.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list