[Bug 699398] mpegvideoparse: couple of issues

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=699398
  GStreamer | gst-plugins-bad | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #243000|none                        |reviewed
             status|                            |

--- Comment #4 from Sebastian Dröge <slomo at circular-chaos.org> 2013-05-03 10:55:41 UTC ---
Review of attachment 243000:
 --> (https://bugzilla.gnome.org/review?bug=699398&attachment=243000)

Is this still needed after

commit f1a6d84a6c4595a94c5654131a74b6a979f53a04
Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Wed May 1 17:36:47 2013 +0100

    mpegvideoparse: don't announce incomplete source caps

    Don't send any source caps yet if we're still in
    drop-buffers-until-we-get-a-sequence-header mode.

    Fixes transmuxing of many MPEG-TS/PS streams into
    formats which require things like width, height or
    codec_data on the input caps.

    Also fixes issues when using playbin with decoder
    sinks that want width/height etc.

    https://bugzilla.gnome.org/show_bug.cgi?id=695879

::: gst/videoparsers/gstmpegvideoparse.c
@@ +480,3 @@
         ret = TRUE;
+      if (!mpvparse->config)
+        ret = FALSE;

Wouldn't this cause the frames before we have a config to be either dropped or
be sent together with the next frame after we got a config? I.e. either lose
data or accumulate multiple frames plus config in the middle in a single
buffer?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.