[Bug 700411] [dmabuf allocator]: optimize map/unmap call

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=700411
  GStreamer | gst-plugins-base | 1.x

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #244384|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge <slomo at circular-chaos.org> 2013-05-16 10:28:16 UTC ---
Review of attachment 244384:
 --> (https://bugzilla.gnome.org/review?bug=700411&attachment=244384)

::: gst-libs/gst/allocators/gstdmabuf.c
@@ +69,3 @@
+  if (mem->data) {
+    GST_INFO("Freeing memory still mapped");
+    munmap ((void *) mem->data, mem->mmap_size);

This should be a g_warning(), it's a programming error to free memory that is
still mapped.

@@ +115,3 @@
     mem->mmap_size = maxsize;
     mem->mmap_count++;
+    gmem->size = maxsize;

Why?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.