[Bug 700654] opencv skin colour detection plugin

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=700654
  GStreamer | gst-plugins-bad | 1.x

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #244730|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge <slomo at circular-chaos.org> 2013-05-20 11:44:57 UTC ---
Review of attachment 244730:
 --> (https://bugzilla.gnome.org/review?bug=700654&attachment=244730)

Why isn't this based on GstVideoFilter or at least GstBaseTransform? Same goes
for many other of the OpenCV elements...

::: ext/opencv/gstskindetect.c
@@ +157,3 @@
+          (G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS)));
+  g_object_class_install_property (gobject_class, PROP_ENABLE,
+      g_param_spec_boolean ("enable", "Enable",

For the other OpenCV filters there is no such property

@@ +162,3 @@
+          (G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS)));
+  g_object_class_install_property (gobject_class, PROP_METHOD,
+      g_param_spec_int ("method",

Please use a GEnum type here and g_param_spec_enum()

@@ +305,3 @@
+
+  buf = gst_buffer_make_writable (buf);
+  gst_buffer_map (buf, &in_info, GST_MAP_WRITE);

Should be GST_MAP_READ as this is only read, not written to.

@@ +318,3 @@
+    }
+  }
+ 
//////////////////////////////////////////////////////////////////////////////

Please use C comments (/* blabla */)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.