[Bug 698837] v4l2: cache CIDs until the device is opened

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=698837
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #244836|none                        |needs-work
             status|                            |

--- Comment #8 from Sebastian Dröge <slomo at circular-chaos.org> 2013-05-21 06:45:51 UTC ---
Review of attachment 244836:
 --> (https://bugzilla.gnome.org/review?bug=698837&attachment=244836)

::: sys/v4l2/gstv4l2object.c
@@ +492,3 @@
           G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
+
+  g_object_class_install_property (gobject_class, PROP_EXTRA_CONTROLS,

Please add a gtk-doc documentation block above this to explain how it's meant
to be used and what it does, also mention CID in the long description of
g_param_spec_boxed()

::: sys/v4l2/v4l2_calls.c
@@ +276,3 @@
+      case V4L2_CTRL_TYPE_INTEGER_MENU:
+      case V4L2_CTRL_TYPE_BITMASK:
+      case V4L2_CTRL_TYPE_BUTTON:{

Are these all "int" typed? Not long, int64, some unsigned variant of these?

@@ +284,3 @@
+            control.name[i] = '_';
+        }
+        GST_WARNING_OBJECT (e, "adding generic controls '%s'", control.name);

This should be GST_DEBUG_OBJECT(), right? It's not a warning

@@ +855,3 @@
+  if (!G_VALUE_HOLDS (value, G_TYPE_INT)) {
+    GST_WARNING_OBJECT (v4l2object,
+        "'int' value expected for control '%s'.", g_quark_to_string
(field_id));

Return from this function here, otherwise you call g_value_get_int() on
something that is not an int

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.