[Bug 700749] gstrtph264pay/depay: Add framerate and optional framesize SDP attribute to payloaded caps

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=700749
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #244873|none                        |needs-work
             status|                            |

--- Comment #7 from Sebastian Dröge <slomo at circular-chaos.org> 2013-05-21 07:17:51 UTC ---
Review of attachment 244873:
 --> (https://bugzilla.gnome.org/review?bug=700749&attachment=244873)

::: gst/rtp/gstrtph264depay.c
@@ +317,3 @@
+        rtph264depay->byte_stream ? "byte-stream" : "avc",
+        "alignment", G_TYPE_STRING, rtph264depay->merge ? "au" : "nal", NULL);
+  }

Just create the caps once and if there's a framerate use gst_caps_set_simple()
to set it on the already created caps

@@ +643,3 @@
+
+    /* canonicalise floating point string so we can handle framerate strings
+     * in the form "24.930" or "24,930" irrespective of the current locale */

The RFC allows both?!

@@ +651,3 @@
+    g_value_set_double (&src, g_ascii_strtod (s, NULL));
+    g_value_init (&dest, GST_TYPE_FRACTION);
+    g_value_transform (&src, &dest);

There's also gst_util_double_to_fraction(), no need for this GValue dance :)

::: gst/rtp/gstrtph264pay.c
@@ +567,3 @@
+    gdouble framerate;
+    gst_util_fraction_to_double (num, denom, &framerate);
+    rate = g_strdup_printf("%f", framerate);

This is always in the format 1.234 with a . as delimiter, right?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.