[Bug 607342] patch that Add 2 news plugins jp462bayer and bayer2rgb2

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue May 21 05:17:04 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=607342
  GStreamer | gst-plugins-bad | git

--- Comment #32 from Joshua M. Doe <oss at nvl.army.mil> 2013-05-21 12:16:58 UTC ---
(In reply to comment #31)
> Still the question about why having this as a separate element instead of
> merging it into the current element and just adding a method property to select
> the algorithm.

I suggest you take a closer look at the patch; the confusion is probably a
result of bad file naming. gstdc1394bayer.c just contains a slightly modified
version of bayer.c from the libdc1394 project, it does not contain another
element. Perhaps the gst prefix should be removed to avoid this confusion,
especially since it doesn't depend on any GStreamer library.

> As the stride with bayer seems to be undefined in general, make a good choice
> for a default that is used often... and then add a GstMeta similar to
> GstVideoMeta to define additional information about the format... like the
> stride.

In my experience with framegrabbers, they don't bother to align strides at all,
however I'll actually most often capture the video as GRAY16 and then use
capssetter, so perhaps we should stick with the 4 byte alignment (this is
actually not a problem with 16-bit bayer, assuming there's never a
half-pattern).

FYI to people other than Sebastian, we were talking here about resurrecting
depth and/or bpp fields for video/x-bayer instead of using formats like bggr16,
in order to support the quite common 10- or 12-bits in 16-bit formats:
https://bugzilla.gnome.org/show_bug.cgi?id=693666

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list