[Bug 700654] opencv skin colour detection plugin

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=700654
  GStreamer | gst-plugins-bad | 1.x

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #244988|none                        |needs-work
             status|                            |

--- Comment #8 from Sebastian Dröge <slomo at circular-chaos.org> 2013-05-22 08:31:13 UTC ---
Review of attachment 244988:
 --> (https://bugzilla.gnome.org/review?bug=700654&attachment=244988)

Almost there :)

::: ext/opencv/gstskindetect.c
@@ +1,3 @@
+/*
+ * GStreamer
+ * Copyright (C) 2013 Miguel Casas-Sanchez <miguelecasassanchez at gmail.com>

Just having your copyright here is fine, I don't see any code copied from
elsewhere except boilerplate code

@@ +95,3 @@
+    static const GEnumValue values[] = {
+      {HSV, "Classic HSV thresholding", "HSV"},
+      {RGB, "RGB-colorspace thresholds", "RGB"},

The last elements here ("HSV", "RGB") should be lower-case for consistency with
other code

@@ +205,3 @@
+  filter->cvGp2 = NULL;
+  filter->cvSkinPixels2 = NULL;
+  filter->cvdraft = NULL;

Setting all this to NULL is not necessary, GObject does that for you already

@@ +222,3 @@
+      break;
+    case PROP_METHOD:
+      filter->method = g_value_get_int (value);

g_value_get_enum()

@@ +241,3 @@
+      break;
+    case PROP_METHOD:
+      g_value_set_int (value, filter->method);

g_value_set_enum()

@@ +259,3 @@
+  CvSize size = cvSize (in_width, in_height);
+
+  filter->cvRGB = cvCreateImageHeader (size, IPL_DEPTH_8U, 3);

You need to check here if these images already exist, in if so free them before
creating new ones. The caps can change at any time

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.