[Bug 686459] pulsesink: playbin uri=x.mp3 audio-sink='identity ! pulsesink' => not-negotiated flow error

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=686459
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #245368|none                        |needs-work
             status|                            |

--- Comment #8 from Sebastian Dröge <slomo at circular-chaos.org> 2013-05-27 09:54:31 UTC ---
Review of attachment 245368:
 --> (https://bugzilla.gnome.org/review?bug=686459&attachment=245368)

::: ext/pulse/pulsesink.c
@@ +2021,3 @@
+          /* raw formats PA supports == raw formats GST supports, so skip
+           * setting formats (FIXME?) */
+          ret = gst_caps_from_string ("audio/x-raw");

gst_caps_new_empty_simple()

Could you also use the GstAudioInfo caps creation function here? There are some
fields missing here :)

@@ +2053,3 @@
+
+  if (pa_format_info_get_prop_int (format, PA_PROP_FORMAT_RATE, &rate) == 0)
+    gst_caps_set_simple (ret, "rate", G_TYPE_INT, rate, NULL);

Should always have rate and channels set, in the worst case the [1,MAX] range.
Alternatively intersect with the template caps afterwards

@@ +2131,3 @@
+  }
+
+  if (!pbuf->stream) {

It should only create a stream and do all that when in >=READY state

@@ +2141,3 @@
+    pa_format_info_set_sample_format (format, PA_SAMPLE_S16LE);
+    pa_format_info_set_rate (format, GST_AUDIO_DEF_RATE);
+    pa_format_info_set_channels (format, GST_AUDIO_DEF_CHANNELS);

Can using this format ever fail although in general stuff would work?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.