[Bug 701316] New: rtspconnection: using g_pollable_stream_read and write breaks builds on Ubuntu and Debian stable

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu May 30 15:12:40 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=701316
  GStreamer | gst-plugins-base | git

           Summary: rtspconnection: using g_pollable_stream_read and write
                    breaks builds on Ubuntu and Debian stable
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: self at brendanlong.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=245682)
 View: https://bugzilla.gnome.org/attachment.cgi?id=245682
 Review: https://bugzilla.gnome.org/review?bug=701316&attachment=245682

Replace g_pollable_stream_{read,write} with the functions that utility function
calls

When I build gst-plugins-base today, I got:

gstrtspconnection.c: In function 'write_bytes':
gstrtspconnection.c:866:5: error: implicit declaration of function
'g_pollable_stream_write' [-Werror=implicit-function-declaration]
gstrtspconnection.c:866:5: error: nested extern declaration of
'g_pollable_stream_write' [-Werror=nested-externs]
gstrtspconnection.c: In function 'fill_raw_bytes':
gstrtspconnection.c:921:5: error: implicit declaration of function
'g_pollable_stream_read' [-Werror=implicit-function-declaration]
gstrtspconnection.c:921:5: error: nested extern declaration of
'g_pollable_stream_read' [-Werror=nested-externs]
cc1: all warnings being treated as errors

The problem is because those two functions were added in GLib 2.34[1], which
isn't available on Ubuntu 12.04 or Debian Wheezy.

This patch just replaces those functions with the functions they call[2].

[1]
https://developer.gnome.org/gio/2.36/gio-gpollableutils.html#g-pollable-stream-write
[2] https://git.gnome.org/browse/glib/tree/gio/gpollableutils.c

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list