[Bug 711230] rtspsrc: allow setting certificate validation flags

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=711230
  GStreamer | gst-plugins-good | 1.2.0

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #258690|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-11-01 13:54:47 UTC ---
Review of attachment 258690:
 --> (https://bugzilla.gnome.org/review?bug=711230&attachment=258690)

Generally looks good

::: gst/rtsp/gstrtspsrc.c
@@ +187,3 @@
 #define DEFAULT_NTP_SYNC         FALSE
 #define DEFAULT_USE_PIPELINE_CLOCK      FALSE
+#define DEFAULT_TLS_VALIDATION_FLAGS G_TLS_CERTIFICATE_VALIDATE_ALL

Isn't the default to validate nothing currently? Changing the default could
break things

@@ +591,3 @@
+   * certificate.
+   *
+   * Since: 1.2.1

Since: 1.4.0 probably

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.