[Bug 705991] Adding support for DASH common encryption to qtdemux and dashdemux

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=705991
  GStreamer | gst-plugins-good | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #258526|none                        |reviewed
             status|                            |

--- Comment #10 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-11-01 14:34:50 UTC ---
Review of attachment 258526:
 --> (https://bugzilla.gnome.org/review?bug=705991&attachment=258526)

Just skipped over this patch, some comments

::: gst/isomp4/qtdemux.c
@@ +6149,3 @@
+
+        case FOURCC_soun:
+          enc_caps = gst_caps_new_simple ("audio/x-cenc",

Why differentiate between audio and video here? Just make it
application/x-cenc?

@@ +6152,3 @@
+              "protection-system-id", G_TYPE_STRING, sys->id,
+              "protection-system-data", GST_TYPE_BUFFER, sys->data,
+              "original-caps", GST_TYPE_CAPS, stream->original_caps, NULL);

I think some unit tests for caps-in-caps would be useful to have in core now :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.