[Bug 711231] gstrtspconnection: allow setting tls certificate validation flags

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=711231
  GStreamer | gst-plugins-base | 1.2.0

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #258737|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-11-01 14:49:35 UTC ---
Review of attachment 258737:
 --> (https://bugzilla.gnome.org/review?bug=711231&attachment=258737)

::: gst-libs/gst/rtsp/gstrtspconnection.c
@@ +482,3 @@
+ * when a TLS connection is established.
+ *
+ * Returns: the validationg flags. If @conn is NULL 0 is returned.

As you've used g_return_val_if_fail(), conn==NULL is considered a programming
error and should not be mentioned at all in the docs. Same above

@@ +491,3 @@
+  g_return_val_if_fail (conn != NULL, 0);
+
+  return g_socket_client_get_tls_validation_flags (conn->client);

What is this doing if this is not a TLS connection?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.