[Bug 711231] gstrtspconnection: allow setting tls certificate validation flags

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=711231
  GStreamer | gst-plugins-base | 1.2.0

--- Comment #6 from Aleix Conchillo Flaqué <aleix at oblong.com> 2013-11-01 15:35:28 UTC ---
(In reply to comment #4)
> Review of attachment 258737 [details]:
> 
> 
> As you've used g_return_val_if_fail(), conn==NULL is considered a programming
> error and should not be mentioned at all in the docs. Same above
> 

OK, didn't notice that convention. Thanks!

> @@ +491,3 @@
> +  g_return_val_if_fail (conn != NULL, 0);
> +
> +  return g_socket_client_get_tls_validation_flags (conn->client);
> 
> What is this doing if this is not a TLS connection?

It just returns the flags that you have set. It doesn't make any check whether
the connection is TLS or not. I guess because you can set it later, that is you
can set and get the flags and later make the client socket TLS.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.