[Bug 708914] Add openni2 plugin and openni2src element

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=708914
  GStreamer | gst-plugins-bad | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #256925|none                        |needs-work
             status|                            |

--- Comment #9 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-11-01 16:28:09 UTC ---
Review of attachment 256925:
 --> (https://bugzilla.gnome.org/review?bug=708914&attachment=256925)

::: ext/openni2/gstopenni2src.cpp
@@ +283,3 @@
     }
   }
+  src->video_frame = (GstVideoFrame*)malloc(sizeof(GstVideoFrame));

Maybe just store the GstVideoFrame on the stack in the functions where you need
it? I see no reason for storing it inside the instance struct

@@ +297,3 @@
     src->color.stop();

+  //free(src->video_frame);

Maybe g_free(src->video_frame); src->video_frame=NULL; here?

@@ +312,1 @@
     return gst_caps_new_empty();

You're leaking the caps created at the top here

@@ +588,3 @@
   /* Is this safe or is a hack? */
+  gst_video_frame_unmap (src->video_frame);
+  //gst_buffer_resize (buf, 0, map.size);

Why?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.