[Bug 710810] geometrictransform: Add a matrix plugin for a 2D perspective transform
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Sat Nov 2 06:56:42 PDT 2013
https://bugzilla.gnome.org/show_bug.cgi?id=710810
GStreamer | gst-plugins-bad | 1.2.0
Antonio Ospite <ospite> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #258024|0 |1
is obsolete| |
--- Comment #2 from Antonio Ospite <ospite at studenti.unina.it> 2013-11-02 13:56:39 UTC ---
Created an attachment (id=258799)
View: https://bugzilla.gnome.org/attachment.cgi?id=258799
Review: https://bugzilla.gnome.org/review?bug=710810&attachment=258799
geometrictransform: add a 2D perspective transform plugin
Hi Sebastian,
an affine transform can be seen as a particular case of perspective
transform that's why I was calling the plugin just "matrix", but I agree
with you that "perspective" is a better name; I am leaving out the
"transform" suffix from the plugin name as the plugin is
a geometrictransform already.
Version 2 attached.
Changes since v1:
- Rename the element from "matrix" to "perspective"
- Rename the "m" property to "matrix"
- Don't include math.h and geometricmath.h in gstperspective.c
I still have a doubt about gst_perspective_get_property() where I am
returning an array allocated in get_array_from_matrix(): whose
responsibility is to free that memory?
The example program has been updated too:
http://git.ao2.it/experiments/gstreamer.git/tree/HEAD:/c/gst-perspective-example
Thanks,
Antonio
P.S. here's the updated "semantic diff" script:
#!/bin/bash
set -e
filter()
{
cat $1 | sed -e 's/ROTATE/PERSPECTIVE/g' \
-e 's/Rotate/Perspective/g' \
-e 's/rotate/perspective/g'
}
diff -pu <(filter gstrotate.h) gstperspective.h | cat
diff -pu <(filter gstrotate.c) gstperspective.c
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list