[Bug 699924] smoothstreaming: no audio with BBC bigbuckbunny stream

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=699924
  GStreamer | gst-plugins-bad | git

--- Comment #18 from Antonio Ospite <ospite at studenti.unina.it> 2013-11-02 14:29:50 UTC ---
My unde(In reply to comment #17)
> Review of attachment 258677 [details]:
> 
> Generally looks good
> 
> ::: ext/smoothstreaming/gstmssmanifest.c
> @@ +588,3 @@
>    gchar *codec_data_str =
>        (gchar *) xmlGetProp (node, (xmlChar *) "CodecPrivateData");
>    GstBuffer *codec_data = NULL;
> 
> Isn't this causing the < 18 byte codec_data to be used still? Shouldn't it
> instead really ignore it and not do anything with it?

CodecPrivateData may not be present at all.

My understanding is that the WaveFormatEx attribute is used as an
_alternative_ to the CodecPrivateData one in older Manifest files.

So as I see it the rationale of the current code is:

  1. Check if "CodecPrivateData" is there, if so set codec_data:
     ...
     structure = gst_caps_get_structure (caps, 0);
     if (codec_data_str && strlen (codec_data_str)) {
       codec_data = gst_buffer_from_hex_string ((gchar *) codec_data_str);
     }
     ...

  2. if codec_data is still null try and see if there is a WaveFormatEx
     attribute.
     ...
     if (!codec_data) {
       GstMapInfo mapinfo;
       codec_data_str = (gchar *) xmlGetProp (node, (xmlChar *)
"WaveFormatEx");
     ...

     [no leaks here, right? because if codec_data is still null then
     codec_data_str was null too]

I think proper handling for "CodecPrivateData" may still be needed to
support other streams, but my patch fixes the issue with WaveFormatEx
which is what this report is really about.

Thanks,
   Antonio

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.