[Bug 711211] avfvideosrc: use input device formats to set/get caps instead of session presets

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=711211
  GStreamer | gst-plugins-bad | git

--- Comment #9 from Andoni Morales <ylatuya at gmail.com> 2013-11-05 17:33:12 UTC ---
(In reply to comment #8)
> (In reply to comment #4)
> > Review of attachment 258929 [details] [details]:
> > 
> > ::: sys/applemedia/avfvideosrc.m
> > @@ +351,3 @@
> > +              found_framerate = TRUE;
> > +              device.activeVideoMinFrameDuration = rate.minFrameDuration;
> > +              device.activeVideoMaxFrameDuration = rate.maxFrameDuration;
> > 
> > This API is only available in OS X 10.9 and IOS 7.0, so you should these
> > property using key-value coding [1] either with try catch or with runtime
> > detection of the current version [2]
> 
> The whole API using device formats and activeFormat is available from OS X 10.7

In OS X we only care about >= 10.7 for this element, the property that's only
available from 10.9 is activeVideoMaxFrameDuration.

> (according to the documentation) and from IOS 7.0. So if we want to support iOS
> < 7.0 we need to keep the old code using the session presets.

For iOS we should try to support as much versions of the SDK as we can. We only
need to have 2 different code paths for setCaps and getCaps here and if
possible do it at runtime rather than at compile time with
__IPHONE_OS_VERSION_MIN_REQUIRED

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.