[Bug 708914] Add openni2 plugin and openni2src element

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=708914
  GStreamer | gst-plugins-bad | unspecified

Miguel (elmiguelao) Casas-Sanchez <miguelecasassanchez> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #255918|0                           |1
        is obsolete|                            |
 Attachment #256925|0                           |1
        is obsolete|                            |

--- Comment #10 from Miguel (elmiguelao) Casas-Sanchez <miguelecasassanchez at gmail.com> 2013-11-06 01:52:17 UTC ---
Created an attachment (id=259053)
 View: https://bugzilla.gnome.org/attachment.cgi?id=259053
 Review: https://bugzilla.gnome.org/review?bug=708914&attachment=259053

2nd full patch openni2 plugin and openni2src element

Comments addressed TTBOMK :) More concretely there were two points:

- the creation of a GstVideoFrame in the read_gstbuffer did not make much
sense to me on second reads. Perhaps I copied it blindly? So what I do now
in openni2_read_gstbuffer() is to create a buffer with g_malloc() and 
associate it with a GstMemory that on free, calls g_free. The buffer is
created and filled in by copying the openni2 data, and sent on. (I could
have associated the openni2 buffer but I'm not sure about its lifetime...).

- the other review was on leaking the caps in gst_openni2_src_get_caps(). 
What I do now is to keep a pointer-ref to the caps in the element structure,
get a reference to the caps the first time and send it on subsequent times. 
This was strongly inspired by gstv4l2src.cpp :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.