[Bug 709224] audio/videodecoder: Not returning GST_FLOW_EOS when after segment

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=709224
  GStreamer | gst-plugins-base | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #259043|none                        |reviewed
             status|                            |

--- Comment #37 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-11-06 15:30:44 UTC ---
Review of attachment 259043:
 --> (https://bugzilla.gnome.org/review?bug=709224&attachment=259043)

::: gst/gstutils.c
@@ +3952,3 @@
+ * gst_flow_combiner_set_flow:
+ * @combiner: the #GstFlowCombiner
+ * @padid: (transfer-none): the #GstFlowCombinerPadId that represents the

(transfer none)

@@ +3964,3 @@
+void
+gst_flow_combiner_set_flow (GstFlowCombiner * combiner,
+    GstFlowCombinerPadId padid, GstFlowReturn fret)

I really don't like the addition of a new type just for identifying pads. That
makes the usage quite ugly, just do this internally or keep the hash table or
just do a linear search in a list or array.

API users should not need to worry about internal optimizations

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.