[Bug 711620] Create a temporary file during FTP transfer/upload

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=711620
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #259195|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-11-07 17:41:28 UTC ---
Review of attachment 259195:
 --> (https://bugzilla.gnome.org/review?bug=711620&attachment=259195)

::: ext/curl/gstcurlftpsink.c
@@ +206,3 @@
+    timeinfo = localtime (&rawtime);
+    strftime (timeinfo_buffer, TIMEINFO_BUFFERSIZE, "%d_%B_%Y_%I_%M_%S_%p",
timeinfo);
+    rename_from = g_strdup_printf ("%s%s%s", RENAME_FROM, tmpfile_name,
timeinfo_buffer);

rename_from is only needed in the "if" part below, and leaked otherwise

@@ +208,3 @@
+    rename_from = g_strdup_printf ("%s%s%s", RENAME_FROM, tmpfile_name,
timeinfo_buffer);
+
+    last_slash = strrchr (basesink->file_name, G_DIR_SEPARATOR);

You probably want to use "/" as a separator always here, instead of "\\" on
Windows. But isn't the filename here guaranteed to be just a filename and the
path is separate from that?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.