[Bug 710034] parse: bison finds conflicts / ambiguities

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=710034
  GStreamer | gstreamer (core) | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #259028|none                        |reviewed
             status|                            |

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-11-11 13:50:29 UTC ---
Review of attachment 259028:
 --> (https://bugzilla.gnome.org/review?bug=710034&attachment=259028)

Looks good in general, but can you provide some additional unit tests that
check if the parser does what it is supposed to do?
Also did you check if all existing unit tests using the parser are still
working fine?

I think this single behaviour change is acceptable and a good idea btw.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.