[Bug 711820] Add min-size property on typefind element

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=711820
  GStreamer | gstreamer (core) | 1.0.7

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #259528|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-11-11 17:02:08 UTC ---
Review of attachment 259528:
 --> (https://bugzilla.gnome.org/review?bug=711820&attachment=259528)

Generally makes sense

::: plugins/elements/gsttypefindelement.c
@@ +218,3 @@
+      g_param_spec_uint ("min-size", _("minimum buffer size of typefinding"),
+          _("minimum buffer size of typefinding"), 0,
+          G_MAXUINT32, 0, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));

Use TYPE_FIND_MIN_SIZE as default here

@@ +288,3 @@
   typefind->caps = NULL;
   typefind->min_probability = 1;
+  typefind->min_size = 0;

And initialize with TYPE_FIND_MIN_SIZE

@@ +879,3 @@
     if (check_avail) {
+      have_min = avail >= (typefind->min_size > TYPE_FIND_MIN_SIZE)
+          ? typefind->min_size : TYPE_FIND_MIN_SIZE;

Then this can just become have_min = (avail >= typefind->min_size);

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.