[Bug 710855] ivfparse: Port to 1.0

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Nov 11 09:16:31 PST 2013


https://bugzilla.gnome.org/show_bug.cgi?id=710855
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #259522|none                        |needs-work
             status|                            |

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-11-11 17:16:27 UTC ---
Review of attachment 259522:
 --> (https://bugzilla.gnome.org/review?bug=710855&attachment=259522)

::: gst/ivfparse/gstivfparse.c
@@ +219,3 @@

+        gst_segment_init (&segment, GST_FORMAT_TIME);
+        gst_pad_push_event (ivf->srcpad, gst_event_new_segment (&segment));

You first need to send a stream-start event, then the caps event, then the
segment event. You don't send a stream-start even currently.

@@ +234,3 @@
+        guint8 data[12];
+
+        gst_adapter_copy (ivf->adapter, data, 0, 12);

Why do you here use copy/flush, and above use take_bytes?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list