[Bug 711607] client: make make_path_from_uri a vmethod

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=711607
  GStreamer | gst-rtsp-server | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #259179|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-11-11 17:49:07 UTC ---
Review of attachment 259179:
 --> (https://bugzilla.gnome.org/review?bug=711607&attachment=259179)

Makes sense I guess :)

::: gst/rtsp-server/rtsp-client.c
@@ +155,3 @@
   klass->params_set = default_params_set;
   klass->params_get = default_params_get;
+  klass->make_path_from_uri = make_path_from_uri;

Better call it default_make_path_from_uri

::: gst/rtsp-server/rtsp-client.h
@@ +93,3 @@
   GstRTSPResult   (*params_set) (GstRTSPClient *client, GstRTSPContext *ctx);
   GstRTSPResult   (*params_get) (GstRTSPClient *client, GstRTSPContext *ctx);
+  gchar *         (*make_path_from_uri) (GstRTSPClient *client, GstRTSPUrl
*uri);

Can the GstRTSPUrl be const? If so, do that

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.