[Bug 711560] rtpsession: ssrc collision improvements

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Nov 12 02:50:33 PST 2013


https://bugzilla.gnome.org/show_bug.cgi?id=711560
  GStreamer | gst-plugins-good | git

--- Comment #12 from Julien Isorce <julien.isorce at gmail.com> 2013-11-12 10:50:28 UTC ---
(In reply to comment #9)
> Review of attachment 259131 [details]:
> 
> This does not seem right:
> 
>  - you call gst_rtp_base_payload_set_outcaps() with NULL, this removes the
> previously configured
>    properties by the subclass.
>  - gst_rtp_base_payload_set_outcaps() negotiates the SSRC with downstream,
> which may or may not have
>    changed.
> 
> What I think should happen is that it changes the SSRC and then updates the
> current caps with
> the new value.

but rtp_base_payload has to get the new ssrc generated form the rtpsession (see
rtpsession:: suggested ssrc) so at some point the rtpbasepayloader has to
qurery caps and this is done in gst_rtp_base_payload_set_outcaps.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list