[Bug 705991] Adding support for DASH common encryption to qtdemux and dashdemux

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=705991
  GStreamer | gst-plugins-good | git

Olivier Crete (Tester) <olivier.crete> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #259772|reviewed                    |needs-work
             status|                            |
 Attachment #259772|reviewed                    |needs-work
             status|                            |

--- Comment #19 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2013-11-14 04:53:56 UTC ---
Review of attachment 259772:
 --> (https://bugzilla.gnome.org/review?bug=705991&attachment=259772)

::: gst/isomp4/qtdemux.c
@@ +1898,3 @@
+      g_array_free (qtdemux->cenc_protection_systems_info, TRUE);
+      qtdemux->cenc_protection_systems_info = NULL;
+    }

This section is not super small and duplicated, can you make it into a separate
function?h

@@ +6175,3 @@
+
+      /* As an initial implementation, we simply choose the first
+       * available protection system. */

I'm a bit concerned that we're ignoring the case where there is more than one
PSSH box in the file. We should design something that works if we don't have a
decrypter for the first PSSH, but only for the second. I think we should design
that in before we're stuck with these caps until 2.x.

--- Comment #20 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2013-11-14 04:54:02 UTC ---
Review of attachment 259772:
 --> (https://bugzilla.gnome.org/review?bug=705991&attachment=259772)

::: gst/isomp4/qtdemux.c
@@ +1898,3 @@
+      g_array_free (qtdemux->cenc_protection_systems_info, TRUE);
+      qtdemux->cenc_protection_systems_info = NULL;
+    }

This section is not super small and duplicated, can you make it into a separate
function?h

@@ +6175,3 @@
+
+      /* As an initial implementation, we simply choose the first
+       * available protection system. */

I'm a bit concerned that we're ignoring the case where there is more than one
PSSH box in the file. We should design something that works if we don't have a
decrypter for the first PSSH, but only for the second. I think we should design
that in before we're stuck with these caps until 2.x.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.