[Bug 678011] typefinding: some mpeg files are not identified as mpeg files

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Nov 13 22:35:55 PST 2013


https://bugzilla.gnome.org/show_bug.cgi?id=678011
  GStreamer | gst-plugins-base | 0.10.36

Jan Schmidt <thaytan> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #259785|none                        |accepted-commit_now
             status|                            |

--- Comment #17 from Jan Schmidt <thaytan at noraisin.net> 2013-11-14 06:35:52 UTC ---
Review of attachment 259785:
 --> (https://bugzilla.gnome.org/review?bug=678011&attachment=259785)

Arguably, by removing the 'no-op divide by 2', you've made the code *less*
readable - since now the len when comparing and then exiting the loop is no
longer the len that was actually peeked, but OK.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list