[Bug 671136] mpegtsmux: add support for SDT and NIT tables for DVB-S/DVB-T

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Nov 15 07:00:53 PST 2013


https://bugzilla.gnome.org/show_bug.cgi?id=671136
  GStreamer | gst-plugins-bad | git

--- Comment #29 from Edward Hervey <bilboed at bilboed.com> 2013-11-15 15:00:49 UTC ---
Review of attachment 258541:
 --> (https://bugzilla.gnome.org/review?bug=671136&attachment=258541)

::: gst-libs/gst/mpegts/gst-dvb-section.c
@@ +702,3 @@
+  start = section->data;
+
+  _packetize_common_section (section);

The 3 lines above could also go in the common part

@@ +749,3 @@
+  }
+
+  /* CRC                              - 32 bit rpchof */

Could maybe be done automatically by the caller of the packetize() method ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list