[Bug 661137] Add support for Commodore tapes

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=661137
  GStreamer | gst-plugins-bad | 0.10.32

Fabrizio Gennari <fabrizio.ge> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #255721|0                           |1
        is obsolete|                            |

--- Comment #6 from Fabrizio Gennari <fabrizio.ge at tiscali.it> 2013-11-16 13:28:41 UTC ---
Created an attachment (id=259963)
 View: https://bugzilla.gnome.org/attachment.cgi?id=259963
 Review: https://bugzilla.gnome.org/review?bug=661137&attachment=259963

255721: Add libgsttap and libgsttapcodec to gst-plugins-bad

Here is a new version of the patch, which should apply to git master. Almost
all of the comments have been addressed. Here's an explanation of which ones
haven't been addressed.

> They don't provide pkg-config files for this?

Unfortunately not

> Just use GstAudioInfo and gst_audio_info_to_caps() here :)

This decoder does not source audio/x-raw, and gst_audio_info_to_caps() seems to
produce only audio/x-raw caps.

> Properly set timestamp and duration on the buffer, based on what you get as
input.

With the new patch, dts and duration are set. I tried setting pts as well, but,
in that case, playing the file to an audio sink produced an audible gap at
regular intervals (

> and also the segment event

I could not find any examples where the segment event is handled, to get
inspiration from. change_state is now handled, and tapenc also handles flushes
(base audio_encoder sending a null frame)

> You don't use these values anywhere else, are they useful?

The only possible output rates from this file format are in tap_clocks, a few
lines below that.

> initially check if you can seek at all. See the seeking query, some muxers are using that

I couldn't find any cases where gst_query_new_seeking() is called initially,
only as a reaction to GST_QUERY_SEEKING.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.