[Bug 709747] wayland_egl: Add support for GstVideoOverlay

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sun Nov 17 14:39:40 PST 2013


https://bugzilla.gnome.org/show_bug.cgi?id=709747
  GStreamer | gst-plugins-gl | git

--- Comment #10 from Matthew Waters <ystreet00 at gmail.com> 2013-11-17 22:39:33 UTC ---
(In reply to comment #9)
> Created an attachment (id=260056)
 View: https://bugzilla.gnome.org/attachment.cgi?id=260056
 Review: https://bugzilla.gnome.org/review?bug=709747&attachment=260056

> wayland_egl: use subsurface to implement GstVideoOverlay interface
> 
> Now use GstContext instead of a property to pass the wl_display instance.
> Also now the engine handles position and resizing from the parent surface.

I think that the display handle should be stored inside subclasses of
GstGLDisplay.  Ideally the idea would be to (all using GstContext) first ask
for a GstGLDisplay and if that fails, ask for winsys specific display handles
and if that also fails then ask for winsys specific display names.  Only after
all that fails do we create our own GstGLDisplay (and hence winsys display). 
Of course this would require extending our code to allow external display
handle sources.

Also, some defined types for display handles should ideally end up in -base as
well, much like the GstEGLDisplay in -bad/gst-libs/gst/egl.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list