[Bug 671136] mpegtsmux: add support for SDT and NIT tables for DVB-S/DVB-T

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=671136
  GStreamer | gst-plugins-bad | git

--- Comment #34 from Jesper Larsen <jesper.larsen at ixonos.com> 2013-11-18 08:36:52 UTC ---
(In reply to comment #32)
> Review of attachment 258649 [details]:
> 
> ::: gst/mpegtsmux/mpegtsmux.c
> @@ +284,3 @@
> +  g_object_class_install_property (G_OBJECT_CLASS (klass), ARG_SI_INTERVAL,
> +      g_param_spec_uint ("si-interval", "SI interval",
> +          "Set the interval (in ticks of the 90kHz clock) for writing out the
> Service"
> 
> Just wondering if it wouldn't be more user friendly to have that in
> GstClockTime

Yes it would. However, the properties for the PAT and PMT intervals are given
in ticks. They should all three be the same.

We can change the PAT/PMT properties as well?

> 
> @@ +1713,3 @@
> +    /* TODO: Implement other section types */
> +    if (GST_MPEGTS_SECTION_TYPE (section) == GST_MPEGTS_SECTION_NIT)
> +      tsmux_add_mpegts_si_section (mux->tsmux, section);
> 
> is the reference transfer properly handled here ?

The section reference is transferred to tsmux_add_mpegts_si_section, which does
not unref the section. The section is inserted in a HashTable, and the
reference is unreffed by the HashTable value free function.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.