[Bug 712368] Fix alignment warnings on ARM compiling

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=712368
  GStreamer | common | 1.0.5

--- Comment #2 from Gabor Rapcsanyi <rgabor at webkit.org> 2013-11-18 08:53:20 UTC ---
(In reply to comment #1)
> Review of attachment 259911 [details]:
> 
> This alignment thing is strange, which exact compiler are you using ?


We are using
gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3
Copyright (C) 2011 Free Software Foundation, Inc.

But we have toolchains made by crosstool-ng and the problem is the same.
For example this code has no warning on x86 but it throws warning on ARM:

g++ -Wcast-align main.cpp

int main() {
  char* a;
  int* b;
  b = reinterpret_cast<int*>(a);
}


> 
> ::: gst/gstbuffer.h
> @@ +331,3 @@
>  gst_buffer_ref (GstBuffer * buf)
>  {
> +  return GST_BUFFER (gst_mini_object_ref (GST_MINI_OBJECT_CAST (buf)));
> 
> use GST_BUFFER_CAST

In gstbuffer.h line 370 you used GST_BUFFER that's why I used it.

gst/gstbuffer.h
367: static inline GstBuffer *
368: gst_buffer_copy (const GstBuffer * buf)
369: {
370:   return GST_BUFFER (gst_mini_object_copy (GST_MINI_OBJECT_CONST_CAST
(buf)));
371: }

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.