[Bug 714998] New: d3dvideosink force-aspect-ratio=false

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=714998
  GStreamer | gst-plugins-bad | unspecified

           Summary: d3dvideosink force-aspect-ratio=false
    Classification: Platform
           Product: GStreamer
           Version: unspecified
        OS/Version: Windows
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: railwar at inbox.ru
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


d3dvidesink without aspect ratio is crushed with message
"6408   0A2C3618 ERROR           d3dvideosink
d3dhelpers.c:1778:d3d_stretch_and_copy:<d3dvideosink0> Failure calling
Direct3DDevice9_StretchRect"

Here is a test batch 
gst-launch-1.0 videotestsrc ! d3dvideosink force-aspect-ratio=false

I have changed code for

  if (sink->force_aspect_ratio)
      hr = IDirect3DDevice9_StretchRect (klass->d3d.device.d3d_device,
sink->d3d.surface,   /* Source Surface */
         &s,                       /* Source Surface Rect (NULL: Whole) */
         back_buffer,              /* Dest Surface */
         &r,                       /* Dest Surface Rect (NULL: Whole) */
         klass->d3d.device.filter_type);
  else
      hr = IDirect3DDevice9_StretchRect (klass->d3d.device.d3d_device,
sink->d3d.surface,   /* Source Surface */
         NULL,                       /* Source Surface Rect (NULL: Whole) */
         back_buffer,              /* Dest Surface */
         NULL,                       /* Dest Surface Rect (NULL: Whole) */
         klass->d3d.device.filter_type);

It works. I think for render_rect=0 (RECT)r is undefined.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.