[Bug 667564] mpeg4videoparse: does not detect config data when VOP only stream is sent

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=667564
  GStreamer | gst-plugins-bad | git

Mark Nauwelaerts <mnauw> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |mnauw at users.sourceforge.net
         Resolution|                            |FIXED

--- Comment #6 from Mark Nauwelaerts <mnauw at users.sourceforge.net> 2013-11-23 10:33:32 UTC ---
Thanks for the report and the investigation, took some time to get around to
this ...

Referring to the dumps above
----
00 00 01 b5                                   // GST_MPEG4_VISUAL_OBJ
09 00 00 01 01
00 00 01 20                                   // GST_MPEG4_VIDEO_LAYER_FIRST
----
There is a VideoObject startcode in there that is not so explicitly flagged;
00 00 01 01

However, the raw data does not have this one and starts directly with
VideoObjectLayer.

So, the problem seems to be that we currently don't allow a frame to start at
VideoObjectLayer, and also do not have this trigger config_found.  That is
arguably strange or a bug, since VideoObject has no real substance/data other
than a startcode.

The link seems no longer valid, so sticking to theory here.

Following commit also allows for VideoObjectLayer to trigger whatever
VideoObject triggers (start of frame, config):

commit fac0f1f668aaa5c39d4d64618c309ca3f732c28a
Author: Mark Nauwelaerts <mnauw at users.sourceforge.net>
Date:   Sat Nov 23 11:23:35 2013 +0100

    mpeg4videoparse: accept VideoObjectLayer as start of frame and config

    ... which it deserves as much as VideoObject.

    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=667564

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.