[Bug 712744] [patch] [matroskamux] Fix handling of negative timestamps

Sat Nov 23 03:27:03 PST 2013

https://bugzilla.gnome.org/show_bug.cgi?id=712744
  GStreamer | gst-plugins-good | 1.2.1

Mark Nauwelaerts <mnauw> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |mnauw at users.sourceforge.net
         Resolution|                            |FIXED

--- Comment #4 from Mark Nauwelaerts <mnauw at users.sourceforge.net> 2013-11-23 11:26:58 UTC ---
Thanks for the bug report.

It probably occurs (much) more in 1.x due to overall changes in (dts/pts)
timestamp handling versus 0.10.

It's not quite clear why the referenced commit is introducing lots of _scale
stuff rather than simply integer arithmetic, since there is no danger of
overflows or so (afaics).  So it is either mostly pointless (?) or I am missing
something else (such as avoiding int64 arithmetic on some platform or ... ?)

As such, have patched this slightly differently while keeping the current
_scale usage.

commit 643e6fdc363b48af7b62536cd084215e66178393
Author: Mark Nauwelaerts <mnauw at users.sourceforge.net>
Date:   Sat Nov 23 12:15:40 2013 +0100

    matroskamux: correctly handle negative relative timestamps

    ... rather than scaling these as unsigned.

    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=712744

    Based on patch by Krzysztof Kotlenga <pocek at users.sf.net>

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.